[webkit-reviews] review denied: [Bug 101139] Expose security origin to BundleFrame : [Attachment 172211] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jon Lee <jonlee at apple.com>'s request for
review:
Bug 101139: Expose security origin to BundleFrame
https://bugs.webkit.org/show_bug.cgi?id=101139

Attachment 172211: Patch
https://bugs.webkit.org/attachment.cgi?id=172211&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172211&action=review


Please add an API test.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:294
> +WKSecurityOriginRef WKBundleFrameGetSecurityOrigin(WKBundleFrameRef
frameRef)
> +{
> +    return toAPI(toImpl(frameRef)->securityOrigin().leakRef());
> +}

This needs to be called WKBundleFrameCopySecurityOrigin and follow copy rules.

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:807
> +    if (!m_coreFrame)
> +	   return WebSecurityOrigin::createFromString(String());

I don't understand why this makes sense.  Why not just return null?