[webkit-reviews] review denied: [Bug 101023] Coordinated Graphics: CoordinatedGraphicsLayer handles a composited image with TiledBackingStore. : [Attachment 171995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 18:44:41 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 101023: Coordinated Graphics: CoordinatedGraphicsLayer handles a composited
image with TiledBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=101023

Attachment 171995: Patch
https://bugs.webkit.org/attachment.cgi?id=171995&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171995&action=review


This will break a really important feature for directly composited images,
which is that they create only one texture per image (e.g. in the leaves demo
we have only 3 leave textures).

I think a better solution would be if we had an actual additional
CoordinatedGraphicsLayer for every composited image, and then the visible rect
for that image would be the union of the visible rects of all contents rects of
the layers that contain that image. 
I can prototype that if you're busy, you seem to be doing a lot lately :)

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:419
> +    else if (m_compositedImageBackingStore)
> +	   m_compositedImageBackingStore->invalidate(IntRect(rect));

This needs to be adjusted to the layer's contentsRect.


More information about the webkit-reviews mailing list