[webkit-reviews] review granted: [Bug 101100] [BlackBerry] Automatically go fullscreen on video play : [Attachment 172148] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Max Feil <mfeil at rim.com>'s
request for review:
Bug 101100: [BlackBerry] Automatically go fullscreen on video play
https://bugs.webkit.org/show_bug.cgi?id=101100

Attachment 172148: Patch
https://bugs.webkit.org/attachment.cgi?id=172148&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172148&action=review


Marking r+, but I would prefer the name change.

> Source/WebCore/html/HTMLMediaElement.cpp:4544
> +bool HTMLMediaElement::mediaPlayerIsFullscreenRestricted() const
> +{
> +    return userGestureRequiredForFullscreen() &&
!ScriptController::processingUserGesture();
> +}

I think it would be better to flip the meaning of the name so you ask if
fullscreen is allowed instead of restricted. Maybe
"mediaPlayerIsFullscreenAllowed", or "mediaPlayerIsFullscreenPermitted"?