[webkit-reviews] review granted: [Bug 101081] webkit-patch rebaseline is broken : [Attachment 172149] clarify bugfix in changelog

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 101081: webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101081

Attachment 172149: clarify bugfix in changelog
https://bugs.webkit.org/attachment.cgi?id=172149&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Not sure whether I prefer this or changing AbstractParallelRebaselineCommand to
check:
if hasattr(options, "results_directory"):

They're both a little gross.

Another option would be to have AbstractParallelRebaselineCommand._rebaseline
not take an options argument at all and just take the individual arguments it
needs to know about. That'd probably be cleanest.

Up to you.