[webkit-reviews] review granted: [Bug 101111] [Mac] ResourceHandle changes for network process : [Attachment 172159] proposed patch

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 101111: [Mac] ResourceHandle changes for network process
https://bugs.webkit.org/show_bug.cgi?id=101111

Attachment 172159: proposed patch
https://bugs.webkit.org/attachment.cgi?id=172159&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172159&action=review


> Source/WebCore/ChangeLog:7
> +

It would be good to give a short summary of why we want to use an
NSOperationQueue here over scheduling with the run loop.

> Source/WebCore/ChangeLog:11
> +	   Add an ability to schedul on an NSOperationQueue. Now that
scheduling on run loop

Typo: "schedul"

> Source/WebCore/platform/network/NetworkingContext.h:27
>  #include "SchedulePair.h"

Nit pick: Don't we always put forward declarations after #includes?