[webkit-reviews] review granted: [Bug 100892] Support X-XSS-Protection: report=URL header syntax in XSSAuditor. : [Attachment 171907] Patch, add changelogs etc.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 100892: Support X-XSS-Protection: report=URL header syntax in XSSAuditor.
https://bugs.webkit.org/show_bug.cgi?id=100892

Attachment 171907: Patch, add changelogs etc.
https://bugs.webkit.org/attachment.cgi?id=171907&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171907&action=review


> Source/WebCore/html/parser/XSSAuditor.cpp:242
> +	       m_parser->document()->addConsoleMessage(JSMessageSource,
LogMessageType, ErrorMessageLevel, "Error parsing header X-XSS-Protection: " +
headerValue + ": "  + errorDetails + " at character position " +
String::format("%u", errorPosition) + ". The default protections will be
applied.");

String::format("%u", errorPosition)  <---  There's a fancier way to do that
which avoids the extra malloc.