[webkit-reviews] review denied: [Bug 100706] [TexMap] Remove unused textures in the texture pool. : [Attachment 171570] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 100706: [TexMap] Remove unused textures in the texture pool.
https://bugs.webkit.org/show_bug.cgi?id=100706

Attachment 171570: Patch
https://bugs.webkit.org/attachment.cgi?id=171570&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171570&action=review


Nice! See comments.

> Source/WebCore/ChangeLog:14
> +	   Changing cache policy is not testabled in layout tests.

testabled -> testable

> Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:36
> +    inline void use() { m_usedTime = monotonicallyIncreasingTime(); }

use -> markUsed

> Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:37
> +    inline static bool compareLRU(const BitmapTexturePoolEntry& a, const
BitmapTexturePoolEntry& b)

inline doesn't help you when you use it as a predicate.
Also, this should be called compareTimeLastUsed

> Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:43
> +    double m_usedTime;

m_timeLastUsed