[webkit-reviews] review denied: [Bug 100977] [WK2] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed : [Attachment 171911] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 100977: [WK2] Crash when calling WebOpenPanelResultListenerProxy::cancel()
after PageClient is destroyed
https://bugs.webkit.org/show_bug.cgi?id=100977

Attachment 171911: Patch
https://bugs.webkit.org/attachment.cgi?id=171911&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This change is OK, but doesn’t seem like the right fix for the bug.

At a time when the PageClient is no longer guaranteed valid the WebPageProxy
should not have a pointer to it any more. That’s the pointer that should be 0,
the pointer to the client. That’s the problem we need to fix. This change
tweaks lifetimes in a way that makes the bug go away in your test case, but
someone else could have a RefPtr to the WebPageProxy that could extend its
lifetime past the life of the PageClient, and we’d see the same problem.

Lets find a real fix; please only make this code change if there’s some other
reason it’s beneficial