[webkit-reviews] review denied: [Bug 101060] Fix the collapsing border code to handle mixed directionality at the row level : [Attachment 172074] Proposed change: fixed the collapsing border code.

Fri Nov 2 09:31:15 PDT 2012

Ojan Vafai <ojan at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 101060: Fix the collapsing border code to handle mixed directionality at
the row level
https://bugs.webkit.org/show_bug.cgi?id=101060

Attachment 172074: Proposed change: fixed the collapsing border code.
https://bugs.webkit.org/attachment.cgi?id=172074&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172074&action=review

r- for the test.

> Source/WebCore/ChangeLog:43
> +	   Updated these functios to work with mixed directionality.

typo: functios

> Source/WebCore/ChangeLog:56
> +	   This is a bug in our implementation: we used to return a non-zero
width for inexistant borders (per CSS 2.1,
> +	   'border-style: off | hidden' should have a 0 width).

I don't see a test for this fix.

> Source/WebCore/rendering/RenderTableSection.cpp:1276
> +    ASSERT_UNUSED(cell, cell->isFirstOrLastCellInRow());

this should just be an ASSERT now.

>
LayoutTests/fast/table/border-collapsing/table-ltr-rows-mixed-direction-expecte
d.html:1
> +<!DOCTYPE>

This doctype is quirksmode I believe. You should be using <!DOCTYPE html>.