[webkit-reviews] review denied: [Bug 101026] Web Inspector: Settings screen: some panel shortcuts are missing : [Attachment 172010] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 101026: Web Inspector: Settings screen: some panel shortcuts are missing
https://bugs.webkit.org/show_bug.cgi?id=101026

Attachment 172010: Patch
https://bugs.webkit.org/attachment.cgi?id=172010&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172010&action=review


> Source/WebCore/ChangeLog:8
> +	   Panels, that hasn't been shown at the moment when shortcuts

Consider rephrasing: .. that have not been loaded by the time shortcuts view
was ..

> Source/WebCore/inspector/front-end/ShortcutsScreen.js:35
> +WebInspector.ShortcutsScreen = function(registrationCallback)

registrationCallback sounds weird too generic.

> Source/WebCore/inspector/front-end/inspector.js:653
> +	   panelDescriptors[i].panel();

We should not create panels just to register their shortcuts. Instead, shortcut
declaration code should be moved into the panel descriptors.