[webkit-reviews] review granted: [Bug 100990] Only resolve attribute-derived style once per shared ElementAttributeData. : [Attachment 172033] Cooler patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 04:37:37 PDT 2012


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 100990: Only resolve attribute-derived style once per shared
ElementAttributeData.
https://bugs.webkit.org/show_bug.cgi?id=100990

Attachment 172033: Cooler patch
https://bugs.webkit.org/attachment.cgi?id=172033&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=172033&action=review


r=me

> Source/WebCore/dom/ElementAttributeData.h:101
> +    void setStyleAttributeIsDirty(bool f) const { m_styleAttributeIsDirty =
f; }
> +    bool presentationAttributeStyleIsDirty() const { return
m_presentationAttributeStyleIsDirty; }
> +    void setPresentationAttributeStyleIsDirty(bool f) const {
m_presentationAttributeStyleIsDirty = f; }

f?!

> Source/WebCore/dom/Node.h:714
> -    // 2 bits remaining
> +    // 4 bits remaining

Nice!


More information about the webkit-reviews mailing list