[webkit-reviews] review granted: [Bug 101007] Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags : [Attachment 171991] Patch 2

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 101007: Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of
other related flags
https://bugs.webkit.org/show_bug.cgi?id=101007

Attachment 171991: Patch 2
https://bugs.webkit.org/attachment.cgi?id=171991&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171991&action=review


rs=me

> Source/WebCore/ChangeLog:10
> +	   ENABLE_INPUT_MULTIPLE_FIELDS_UI is disabled. So they should be
warpped

Typo: wrapped

> Source/WebCore/ChangeLog:32
> +	    2) WebCore/Resources/pagepopus/ is used for the calendar UI
implementation.

Typo: pagepopups

> Source/WebCore/ChangeLog:39
> +	   date/tiem InputType classes.

Typo: date/time

> Source/WebCore/ChangeLog:42
> +	   * page/ChromeClient.h: Change the flag for openDateTimChooser, and
add a comment.

Typo: openDateTimeChooser

> Source/WebCore/ChangeLog:51
> +	   ENABEL(INPUT_MULTIPLE_FIELDS_UI).

Typo: ENABLE

> Source/WebCore/page/ChromeClient.h:233
> +	   //	 returns true, if ENABEL(INPUT_MULTIPLE_FIELDS_UI)

Typo: ENABLE

> Source/WebCore/page/ChromeClient.h:235
> +	   //	 ENABEL(INPUT_MULTIPLE_FIELDS_UI)

Typo: ENABLE

> Source/WebCore/platform/text/PlatformLocale.cpp:351
> +

Nit: A redundant empty line.