[webkit-reviews] review granted: [Bug 101024] Introduce Month class to calendar picker : [Attachment 172026] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 101024: Introduce Month class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101024

Attachment 172026: Patch
https://bugs.webkit.org/attachment.cgi?id=172026&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172026&action=review


ok

> Source/WebCore/ChangeLog:23
> +	   (Month.prototype.start): Returns a datetime that is the start of
this month. The value is inclusive.
> +	   (Month.prototype.end): Returns a datetime that is the end of this
month. The value is exclusive.

Need to update

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1118
> +    var currentMonthStart = currentMonth.startDate();
> +    if (this.picker.minimumDate >= currentMonthStart)

nit: You can remove the local variable 'currentMonthStart'.