[webkit-reviews] review denied: [Bug 101021] Web Inspector: add console.clear() : [Attachment 172003] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 101021: Web Inspector: add console.clear()
https://bugs.webkit.org/show_bug.cgi?id=101021

Attachment 172003: Patch
https://bugs.webkit.org/attachment.cgi?id=172003&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172003&action=review


> Source/WebCore/inspector/ConsoleMessage.cpp:115
> +    case ClearConsoleMessageType: return
TypeBuilder::Console::ConsoleMessage::Type::Clear;

Drop "Console", it's cleaner.

> Source/WebCore/inspector/front-end/ConsoleMessage.js:80
> +		       this._messageElement =
document.createTextNode("console.clear()");

I would say "Console was cleared" with gray. You'll need to put it into
WebCore/English.lproj/localizedStrings.js

> LayoutTests/inspector/console/console-clear-function-expected.txt:11
> +console.clear()

Sounds like the source location is missing.

> LayoutTests/inspector/console/console-clear-function.html:22
> +    RuntimeAgent.evaluate("console.clear();", function() {

Use named functions (step1)