[webkit-reviews] review granted: [Bug 100969] [EFL][WK2] Remove redundant internal function : [Attachment 171883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 22:44:34 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 100969: [EFL][WK2] Remove redundant internal function
https://bugs.webkit.org/show_bug.cgi?id=100969

Attachment 171883: Patch
https://bugs.webkit.org/attachment.cgi?id=171883&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171883&action=review


Yes, right. Thanks.

> Source/WebKit2/ChangeLog:8
> +	   Remove ewk_view_text_found() in ewk_view.cpp which is not used
anymore.

It would be good if you say this signal is emitted by
DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned) in
EwkViewCallback.h instead.


More information about the webkit-reviews mailing list