[webkit-reviews] review granted: [Bug 97427] [EFL][DRT] Support Geolocation : [Attachment 171814] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted seonae kim
<sunaeluv.kim at samsung.com>'s request for review:
Bug 97427: [EFL][DRT] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97427

Attachment 171814: Patch
https://bugs.webkit.org/attachment.cgi?id=171814&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171814&action=review


> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:200
> +    DumpRenderTreeSupportEfl::setDumpRenderTreeModeEnabled(true);

Add a comment why you need this setting.

For example,
// Set running in DRT mode for ewkview to create testable objects.

In addition, it would be good if you call this by alphabetical order.