[webkit-reviews] review granted: [Bug 100533] [CSS Shaders] CustomFilterOperation should be converted to ValidatedCustomFilterOperation before using it : [Attachment 171950] Patch V2

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 100533: [CSS Shaders] CustomFilterOperation should be converted to
ValidatedCustomFilterOperation before using it
https://bugs.webkit.org/show_bug.cgi?id=100533

Attachment 171950: Patch V2
https://bugs.webkit.org/attachment.cgi?id=171950&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171950&action=review


> Source/WebCore/ChangeLog:44
> +	   layer is updated. Otherwise the composited layer will never see a
loaded filter in the first call.
> +
> +	   (WebCore):
> +	   (WebCore::RenderLayer::isCSSCustomFilterEnabled):
> +	   (WebCore::RenderLayer::computeFilterOperations):
> +	   (WebCore::RenderLayer::updateOrRemoveFilterClients): Split
updateOrRemoveFilterEffect into 2 functions.
> +	   This one is supposed to add the clients needed to load network
resources.
> +
> +	   (WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer): Figures
out if a software fallback is needed 
> +	   and creates a FilterEffectRenderer.
> +
> +	   * rendering/RenderLayer.h:

You have a few blank lines in there.

> Source/WebCore/platform/graphics/filters/ValidatedCustomFilterOperation.h:68
> +    CustomFilterMeshType meshType() const { return m_meshType; }
>  private:
> +    
>      virtual bool operator==(const FilterOperation& o) const

I actually was asking for the empty line between meshType() and private :)