[webkit-reviews] review granted: [Bug 100994] Ensure that AudioNode deletion is synchronized with a stable state of the rendering graph : [Attachment 171944] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 100994: Ensure that AudioNode deletion is synchronized with a stable state
of the rendering graph
https://bugs.webkit.org/show_bug.cgi?id=100994

Attachment 171944: Patch
https://bugs.webkit.org/attachment.cgi?id=171944&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171944&action=review


This fix looks OK but there's a comment that needs to be updated. Please do
that before landing. r=me

> Source/WebCore/Modules/webaudio/AudioContext.cpp:786
> +	       m_nodesToDelete.append(m_nodesMarkedForDeletion[i]);

There is now a stale comment about m_nodesToDelete in
AudioContext::deleteMarkedNodes() that needs to be adjusted.