[webkit-reviews] review granted: [Bug 99647] HTMLMediaPlayer should free m_player when src is set/changed : [Attachment 171940] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 99647: HTMLMediaPlayer should free m_player when src is set/changed
https://bugs.webkit.org/show_bug.cgi?id=99647

Attachment 171940: Patch
https://bugs.webkit.org/attachment.cgi?id=171940&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171940&action=review


Thanks for keeping at this!

> Source/WebCore/html/HTMLMediaElement.cpp:374
> +	       m_loadTimer.stop();
> +	       m_progressEventTimer.stop();
> +	       m_playbackProgressTimer.stop();
> +	       m_pendingLoadFlags &= ~MediaResource;
> +	       m_loadState = WaitingForSource;
> +#if !ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +	       m_player.clear();
> +#endif

We do all of these in HTMLMediaElement::userCancelledLoad, although
m_pendingLoadFlags is set to 0. It would be nice to have both use a shared
function that took a flags mask.