[webkit-reviews] review granted: [Bug 100978] [BlackBerry] Add more form validation strings : [Attachment 171938] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 14:53:50 PDT 2012
Yong Li <yoli at rim.com> has granted Rob Buis <rwlbuis at gmail.com>'s request for
review:
Bug 100978: [BlackBerry] Add more form validation strings
https://bugs.webkit.org/show_bug.cgi?id=100978
Attachment 171938: Patch
https://bugs.webkit.org/attachment.cgi?id=171938&action=review
------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review
> Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464
> + return
String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDE
RFLOW), text.utf8().data());
it would be nice if we verify the format string in debug build, to make sure
there is only one %, which is %s.
More information about the webkit-reviews
mailing list