[webkit-reviews] review granted: [Bug 100533] [CSS Shaders] CustomFilterOperation should be converted to ValidatedCustomFilterOperation before using it : [Attachment 171743] Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 14:14:56 PDT 2012


Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 100533: [CSS Shaders] CustomFilterOperation should be converted to
ValidatedCustomFilterOperation before using it
https://bugs.webkit.org/show_bug.cgi?id=100533

Attachment 171743: Patch V1
https://bugs.webkit.org/attachment.cgi?id=171743&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171743&action=review


> Source/WebCore/platform/graphics/filters/ValidatedCustomFilterOperation.h:66
> +    CustomFilterMeshType meshType() const { return m_meshType; }
>  private:

Nit: space between these lines

> Source/WebCore/rendering/FilterEffectRenderer.cpp:342
> +	       // CUSTOM operations are alwasy converted to VALIDATED_CUSTOM
before getting here.

typo "always"


More information about the webkit-reviews mailing list