[webkit-reviews] review granted: [Bug 100979] Fix HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) build : [Attachment 171923] with more fixes

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 100979: Fix HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) build
https://bugs.webkit.org/show_bug.cgi?id=100979

Attachment 171923: with more fixes
https://bugs.webkit.org/attachment.cgi?id=171923&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171923&action=review


r=me

> Source/WTF/wtf/Platform.h:595
> +#define HAVE_NETWORK_CFDATA_ARRAY_CALLBACK 1 // FIXME: All CFNetwork based
platforms have this callback now, so it should be USE, not HAVE.

I agree. Should you just change this now? Modifying Platform.h to have this
comment will cause everyone to need to do a full build anyways.