[webkit-reviews] review granted: [Bug 100675] [chromium] Provide WebKit API interface for platform gesture curves : [Attachment 171849] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 100675: [chromium] Provide WebKit API interface for platform gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100675

Attachment 171849: Patch
https://bugs.webkit.org/attachment.cgi?id=171849&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
R=me

Re putting it in Source/WebKit/chromium/src vs Source/Platform/chromium/src: we
have two WebKit APIs, a client API (lives in WebKit/chromium/public) and a
platform API (Platform/chromium/public).  The ideal is to keep dependencies a
DAG.  Implementations of the client API can depend on all of WebKit since users
of the client API are depending on WebKit.  The client API can't be used by
anything outside of the WebKit layer (meaning WebCore / Platform can't use
client API concepts).  Implementations of the platform API can't depend on
anything in WebKit outside of the platform API, but anything in
WebKit/WebCore/Platform can depend on them.

Since you've defined Web*Gesture* as part of the platform API, the
implementation belongs in the Platform location.  This means anything in
WebKit/WebCore/Platform are able to depend on it.  If the only caller is in the
client API implementation (WebViewImpl) then if you want you can move the whole
thing to the client API.  I think we'll want to depend on this from
WebCore/platform/ScrollAnimatorNone so I'd be inclined to leave it where it is.