[webkit-reviews] review granted: [Bug 97801] Support invalidation tracking for composited layers : [Attachment 171890] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 10:57:05 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted vollick at chromium.org's
request for review:
Bug 97801: Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801

Attachment 171890: Patch
https://bugs.webkit.org/attachment.cgi?id=171890&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171890&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:2066
> +bool RenderLayerCompositor::isTrackingRepaints() const
> +{
> +    FrameView* frameView = m_renderView ? m_renderView->frameView() : 0;
> +    if (!frameView)
> +	   return false;
> +    FrameView* rootFrameView = frameView->frame()->tree()->top()->view();
> +    if (!rootFrameView)
> +	   return false;
> +    return rootFrameView->isTrackingRepaints();
> +}

This code is going to run in release builds. I wonder if we should cache the
flag in RLC?


More information about the webkit-reviews mailing list