[webkit-reviews] review granted: [Bug 100965] [V8] The DOMWrapperVisitor abstraction is no longer needed : [Attachment 171874] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 09:41:45 PDT 2012
Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 100965: [V8] The DOMWrapperVisitor abstraction is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100965
Attachment 171874: Patch
https://bugs.webkit.org/attachment.cgi?id=171874&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171874&action=review
> Source/WebCore/bindings/v8/ScriptProfiler.cpp:215
> + class VisitorAdapter : public v8::PersistentHandleVisitor {
Nit: I would slightly prefer DOMObjectWrapperVisitor than VisitorAdapter. Also
you can rename VisitorAdaptor for Nodes to DOMNodeWrapperVisitor.
More information about the webkit-reviews
mailing list