[webkit-reviews] review denied: [Bug 100797] Coordinated Graphics: Manage the lifecycle of shareable surfaces precisely. : [Attachment 171771] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 100797: Coordinated Graphics: Manage the lifecycle of shareable surfaces
precisely.
https://bugs.webkit.org/show_bug.cgi?id=100797

Attachment 171771: Patch
https://bugs.webkit.org/attachment.cgi?id=171771&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171771&action=review


Some nitpicks, otherwise good!

> Source/WebKit2/ChangeLog:19
> +	   file handle every tile update. UI Proces does not need to create a

Proces -> Process

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:82

> +#ifndef NDEBUG
> +    SurfaceMap::iterator it = m_surfaces.find(atlasID);
> +    ASSERT(it == m_surfaces.end());
> +#endif

ASSERT(!m_surfaces.contains(atlasID))

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:91

> +#ifndef NDEBUG
> +    SurfaceMap::iterator it = m_surfaces.find(atlasID);
> +    ASSERT(it != m_surfaces.end());
> +#endif

ditto

> Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp:39
> +    static int id = 0;

id -> nextID