[webkit-reviews] review denied: [Bug 97171] Support the replace attribute of window.open : [Attachment 171800] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 97171: Support the replace attribute of window.open
https://bugs.webkit.org/show_bug.cgi?id=97171

Attachment 171800: Patch
https://bugs.webkit.org/attachment.cgi?id=171800&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171800&action=review


Looks like you have compile and test failures.

> Source/WebCore/page/DOMWindow.cpp:1933
> +	   bool lockHistory = false, lockBackForwardList = false;
> +	   if (locking == LockHistoryAndBackForwardList)
> +	       lockHistory = lockBackForwardList = true;

This is pretty far out of style.  Please take a look at
http://www.webkit.org/coding/coding-style.html