[webkit-reviews] review canceled: [Bug 100858] [EFL][WK2] Add Ewk_Auth_Request API : [Attachment 171834] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 1 07:23:23 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 100858: [EFL][WK2] Add Ewk_Auth_Request API
https://bugs.webkit.org/show_bug.cgi?id=100858

Attachment 171834: Patch
https://bugs.webkit.org/attachment.cgi?id=171834&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Call AuthenticationClient::receivedRequestToContinueWithoutCredential() from
WebCoreSynchronousLoader::didReceiveAuthenticationChallenge() so that we don't
handle authentication for synchronous XMLHTTPRequests.

This fixes a regression in:
  http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

BTW, the GTK EWS seems broken and its warning is unrelated to my patch.


More information about the webkit-reviews mailing list