[webkit-reviews] review denied: [Bug 58378] Add WebCore::Setting to block displaying and/or running insecure content on secure pages : [Attachment 155814] Plumbing #3

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied  review:
Bug 58378: Add WebCore::Setting to block displaying and/or running insecure
content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378

Attachment 155814: Plumbing #3
https://bugs.webkit.org/attachment.cgi?id=155814&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
The new API looks OK to me, let's wait for a second review, I'll set r- instead
of setting cq+ because of the required changes above.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1020
> +    * Whether is it possible for pages loaded via HTTPS to display
> +    * subresources, such as images and frames, from non-HTTPS URLs.

Can we reword this to "Whether pages loaded via HTTPS should load subresources
such as images and frames from non-HTTPS URLs."?

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1022
> +    * Since: 1.9.5

Since tags should say 2.0, since that's going to be the next stable release.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1037
> +    * Whether is it possible for pages loaded via HTTPS to run
> +    * subresources, such as CSS, scripts and plugins, from non-HTTPS
> +    * URLs.

Same rewording here would be good.