[webkit-reviews] review denied: [Bug 97427] [EFL][DRT] Support Geolocation : [Attachment 171785] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied  review:
Bug 97427: [EFL][DRT] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97427

Attachment 171785: Patch
https://bugs.webkit.org/attachment.cgi?id=171785&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171785&action=review


> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:89
> +    WebCore::provideGeolocationTo(page, mock);

Sorry. I missed one. If we add this one to here, we add GeolocationClient
twice. One is ewk_view and other is here.

Because, you will add a GeolocationClientEfl to WebCore's supplement in
_ewk_view_priv_new, right ? When we run layout test, GeolocationClient will be
added twice by this. It might to make assertion.

We have to follow other ports's implementation using a flag. (e.g. s_drt ?)