[webkit-reviews] review denied: [Bug 100932] User can change a disabled select (drop down box) : [Attachment 171801] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kunihiko Sakamoto
<ksakamoto at chromium.org>'s request for review:
Bug 100932: User can change a disabled select (drop down box)
https://bugs.webkit.org/show_bug.cgi?id=100932

Attachment 171801: Patch
https://bugs.webkit.org/attachment.cgi?id=171801&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171801&action=review


> Source/WebCore/html/HTMLFormControlElement.cpp:154
> +    if (disabled() && focused())
> +	   blur();
>      setNeedsWillValidateCheck();

Unfortunately, this is not acceptable.	blur() dispatches a 'blur' event, and
Event handler JavaScript code can delete |this| object.

Probably we should make blur/focusout/DOMFocusOut/focus/focusin/DOMFocusIn
events scoped-events, like I did in http://trac.webkit.org/changeset/132983