[webkit-reviews] review granted: [Bug 88014] sandbox directive in X-WebKit-CSP header unable to create a unique origin : [Attachment 145196] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 23:01:28 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 88014: sandbox directive in X-WebKit-CSP header unable to create a unique
origin
https://bugs.webkit.org/show_bug.cgi?id=88014

Attachment 145196: Patch
https://bugs.webkit.org/attachment.cgi?id=145196&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145196&action=review


> Source/WebCore/ChangeLog:11
> +	   sandbox directive in CSP couldn't create a unique origin.

Please add URLs of the relevant specs.

> Source/WebCore/dom/Document.cpp:5036
> -void Document::initContentSecurityPolicy()
> +void Document::didUpdateSecurityOrigin()

Could you swap the order of these two functions so that the diff looks saner?


More information about the webkit-reviews mailing list