[webkit-reviews] review granted: [Bug 87686] [chromium] Accelerated animations should use WebTransformOperations : [Attachment 145194] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 19:59:09 PDT 2012


James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 87686: [chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686

Attachment 145194: Patch
https://bugs.webkit.org/attachment.cgi?id=145194&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145194&action=review


Nice! R=me, but I'm pretty sure that http://trac.webkit.org/changeset/119178
has given you the gift of many merge conflicts.

> Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp:75
> +	       ScaleTransformOperation* transform =
static_cast<ScaleTransformOperation*>(transformOperations.operations()[j].get()
);

I think using temporaries like this is fine, but can we const it up a bit?


More information about the webkit-reviews mailing list