[webkit-reviews] review denied: [Bug 87859] Bug: Negative SVG rect rx, ry corner radii values aren't handled correctly : [Attachment 145163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 15:57:28 PDT 2012


Dirk Schulze <krit at webkit.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 87859: Bug: Negative SVG rect rx,ry corner radii values aren't handled
correctly
https://bugs.webkit.org/show_bug.cgi?id=87859

Attachment 145163: Patch
https://bugs.webkit.org/attachment.cgi?id=145163&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145163&action=review


Looks good to me. Just snippets to get r+.

> LayoutTests/svg/custom/rect-negative-corner-radii-expected.svg:2
> +<svg xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg" version="1.0" width="500" height="500">

xmlns:svg="http://www.w3.org/2000/svg" Is unnecessary.

> LayoutTests/svg/custom/rect-negative-corner-radii.svg:2
> +<svg xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg" version="1.0" width="500" height="500">

Ditto.


More information about the webkit-reviews mailing list