[webkit-reviews] review granted: [Bug 87847] [Qt] Make conversion from QString to WTF::String (and back again) ~free : [Attachment 145089] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Tor Arne Vestbø
<vestbo at webkit.org>'s request for review:
Bug 87847: [Qt] Make conversion from QString to WTF::String (and back again)
~free
https://bugs.webkit.org/show_bug.cgi?id=87847

Attachment 145089: Patch
https://bugs.webkit.org/attachment.cgi?id=145089&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This seems fine to me.	We've discussed refactoring the various backing buffers
behind an extra layer of abstraction at some point, with a virtual interface so
we can move knowledge of the set of supported types out of backing buffers out
of StringImpl.	But if we do want to make a change like that, we could easily
make QStringData one of the types of supported buffers.