[webkit-reviews] review granted: [Bug 87149] Move setFrameFlatteningEnabled from layoutTestController to window.internals() : [Attachment 144607] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 87149: Move setFrameFlatteningEnabled from layoutTestController to
window.internals()
https://bugs.webkit.org/show_bug.cgi?id=87149

Attachment 144607: Patch
https://bugs.webkit.org/attachment.cgi?id=144607&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144607&action=review


> Source/WebKit/win/WebPreferences.h:419
> +    // FIXME: These can be removed after the move from layouttestcontroller

Nit: here and above, i think this needs a bit more qualification. Maybe
something like "These can be removed if there are no Apple-internal calls to
this. See http://webkit.org/b/87148."

You don't need to say the "after the move..." bit because this is the commit
that makes that change. Otherwise, it sounds like it's blocked on something
else getting committed.

> Tools/ChangeLog:9
> +	   During the InternalsObject reset the behavior is changed back to the
platform

nit: s/During/during