[webkit-reviews] review requested: [Bug 87766] [chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation : [Attachment 145126] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 87766: [chromium] Ensure that skipping frames during an accelerated
animation doesn't cause starvation
https://bugs.webkit.org/show_bug.cgi?id=87766

Attachment 145126: Patch
https://bugs.webkit.org/attachment.cgi?id=145126&action=review

------- Additional Comments from vollick at chromium.org
I've discussed m_lastFrameNumberWhereDrawWasCalled with Dana and concluded that
it can't be used in this patch, nor can we share state to accomplish our goals.

Dana's goal: detect if we've already attempted to draw this frame (so that we
don't try twice).

My goal: count the number of failed draws (to eventually force a draw).

We need different state to accomplish these two goals. Another point that came
up in our discussion was that when it comes time to force a draw, it doesn't
makes sense to try drawing until the next commit when we have, hopefully, some
new textures. So instead of setting m_needsForcedDraw, I instead set a new
member m_needsForcedDrawAfterNextCommit, which does what you'd expect.