[webkit-reviews] review denied: [Bug 87913] [chromium] Work around lost context assertion failures in compositor startup : [Attachment 144976] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 10:20:33 PDT 2012


James Robinson <jamesr at chromium.org> has denied Kenneth Russell
<kbr at google.com>'s request for review:
Bug 87913: [chromium] Work around lost context assertion failures in compositor
startup
https://bugs.webkit.org/show_bug.cgi?id=87913

Attachment 144976: Patch
https://bugs.webkit.org/attachment.cgi?id=144976&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Test failure needs to be looked at.  It's one thing for the failure to not show
up in DRT without a patch, it's another for the test to fail in DRT.  Why does
the expected png appear to have red boxes in it?

It looks like this doesn't really solve any problems, just moves things around
- we can lose the context at any point and need to be robust to that.


More information about the webkit-reviews mailing list