[webkit-reviews] review requested: [Bug 87873] [chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized : [Attachment 145096] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 87873: [chromium] Single thread proxy should not tick animations unless the
layer renderer has been initialized
https://bugs.webkit.org/show_bug.cgi?id=87873

Attachment 145096: Patch
https://bugs.webkit.org/attachment.cgi?id=145096&action=review

------- Additional Comments from vollick at chromium.org
CCLayerTreeHost::finishAllRendering is called iff we are shutting down
accelerated compositing. If we are shutting down accelerated compositing, it
makes sense to stop CCSingleThreadProxy's timer here so it never fires after
we've switched to software mode. This required a minor change to
finishAllRendering. Previously, CCLTH::finishAllRendering bailed early if we
hadn't initialized the layer renderer (which foils the plan to stop the timer).
Now, the proxy's know that this function may be called without an initialized
layer renderer and have the appropriate checks.

I've added a unit test to ensure that we do indeed stop the timer in this case.