[webkit-reviews] review denied: [Bug 85527] [Qt][WK2] Add support for multi-select list : [Attachment 144606] Patch with fixes

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 85527: [Qt][WK2] Add support for multi-select list
https://bugs.webkit.org/show_bug.cgi?id=85527

Attachment 144606: Patch with fixes
https://bugs.webkit.org/attachment.cgi?id=144606&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144606&action=review


>
Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml:24
> +		   model.close()

I don't like this change. All the dialogs have accept(), reject(), and
dismiss(), where the latter is a neutral "close" and the two former implies the
latter.

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_multiSelect.qml:26

> +	   Timer {
> +	       running: true
> +	       interval: 1
> +	       onTriggered: {
> +		   var selectedIndices = [0,1]
> +		   if (model.allowMultiSelect && selectItems){
> +		       for (var i = 0; i <  selectedIndices.length; i++)
> +			   model.accept(selectedIndices[i])
> +		   }
> +		   model.close();

There's no need for a timer here anymore, you should be able to do the test in 
Component.onCompleted: {} like the other dialog tests do.