[webkit-reviews] review granted: [Bug 87953] [SOUP] WebProcess crashes when a download is started from an existing ResourceHandle : [Attachment 145045] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 87953: [SOUP] WebProcess crashes when a download is started from an
existing ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=87953

Attachment 145045: Patch
https://bugs.webkit.org/attachment.cgi?id=145045&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145045&action=review


> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:154
> +    // If the handle already got a response, make sure the download client
is notified.
> +    ResourceHandleInternal* handleInternal =
m_resourceHandle->getInternal();
> +    if (!handleInternal->m_response.isNull())
> +	   m_downloadClient->didReceiveResponse(m_resourceHandle.get(),
handleInternal->m_response);

Is there a chance that data has already been received or the request already
failed as well? If that was the case then we'd have to forward those events. Or
is the resource handle paused during policy decisions?