[webkit-reviews] review denied: [Bug 87936] [Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls. : [Attachment 145011] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied  review:
Bug 87936: [Qt][WK2] Add missing ViewportUpdateDeferrer guarding to
setPageItemRectVisible() calls.
https://bugs.webkit.org/show_bug.cgi?id=87936

Attachment 145011: Patch
https://bugs.webkit.org/attachment.cgi?id=145011&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review


> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
>  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)

>  {
> +    ViewportUpdateDeferrer guard(this);
>      setPageItemRectVisible(value.toRectF());
>  }

This one is not needed... it should be guarded already