[webkit-reviews] review denied: [Bug 87844] Implement painting slider tick marks : [Attachment 144987] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 87844: Implement painting slider tick marks
https://bugs.webkit.org/show_bug.cgi?id=87844

Attachment 144987: Patch
https://bugs.webkit.org/attachment.cgi?id=144987&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144987&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests. Tests will be added when turned on.

This patch affect platforms with ENABLE_DATALIST, right?  So, we need tests
now.

> Source/WebCore/rendering/RenderThemeChromiumLinux.h:63
> +	   virtual Color sliderTickColor() const;
> +	   virtual IntSize sliderTickSize() const;
> +	   virtual IntSize sliderThumbSize() const;
> +	   virtual int sliderTickOffsetFromTrackCenter() const;

Need OVERRIDE.