[webkit-reviews] review granted: [Bug 87310] WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers : [Attachment 144935] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 30 17:27:53 PDT 2012
Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 87310: WebKit incorrectly clears the alpha channel on readPixels, even for
Framebuffers
https://bugs.webkit.org/show_bug.cgi?id=87310
Attachment 144935: Patch
https://bugs.webkit.org/attachment.cgi?id=144935&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144935&action=review
Looks good. r=me
>
LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.
html:170
> + shouldBe("pixel", "[127, 127, 127, 127]");
I could imagine this test being flaky. Should it have a one-pixel value
tolerance?
More information about the webkit-reviews
mailing list