[webkit-reviews] review granted: [Bug 87901] Avoid second layout for flex-direction:row, flex-basis:auto flex items : [Attachment 144928] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 87901: Avoid second layout for flex-direction:row, flex-basis:auto flex
items
https://bugs.webkit.org/show_bug.cgi?id=87901

Attachment 144928: Patch
https://bugs.webkit.org/attachment.cgi?id=144928&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144928&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:997
> +	   // FIXME: If we're overriding logicalHeight (i.e.
hasOrthogonalFlow(child) == true), we only need to layout here if the
> +	   // contents of the child depends on it's height (e.g. % height
elements, background-color, etc) because we already
> +	   // layed out once in computeMainAxisPreferredSizes at the unflexed
height.

Nit: Might be easier to file a bug about this and dump some of this in the bug
instead.