[webkit-reviews] review granted: [Bug 87714] Mac crash logs can take a really long time to be written out. : [Attachment 144924] reworked patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 14:45:16 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 87714: Mac crash logs can take a really long time to be written out.
https://bugs.webkit.org/show_bug.cgi?id=87714

Attachment 144924: reworked patch
https://bugs.webkit.org/attachment.cgi?id=144924&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144924&action=review


Looks good. thanks!

> Tools/Scripts/webkitpy/layout_tests/port/mac.py:204
> +	       _log.warning('no crash log found for %s:%d' %
(self._crashed_process_name, self._crashed_pid))

This line should be deleted, right?


More information about the webkit-reviews mailing list