[webkit-reviews] review granted: [Bug 87808] [Qt] handled touchmove events should not cancel tap gesture recognition : [Attachment 144870] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 87808: [Qt] handled touchmove events should not cancel tap gesture
recognition
https://bugs.webkit.org/show_bug.cgi?id=87808

Attachment 144870: patch
https://bugs.webkit.org/attachment.cgi?id=144870&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review


>>> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439
>>> -	     resetGestureRecognizers();
>> 
>> Maybe that method is useless now? Did you check?
> 
> It is used by QQuickWebViewPrivate::processDidCrash.

OK, but I guess I will just do the cancels explicitly there instead...