[webkit-reviews] review granted: [Bug 87897] Inline blocks with margin wrap incorrectly with subpixel layout turned on : [Attachment 144921] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 87897: Inline blocks with margin wrap incorrectly with subpixel layout
turned on
https://bugs.webkit.org/show_bug.cgi?id=87897

Attachment 144921: Patch
https://bugs.webkit.org/attachment.cgi?id=144921&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144921&action=review


> Source/WebCore/rendering/RenderBlock.cpp:5512
> -		       float bpm =
getBorderPaddingMargin(toRenderInline(child), childIterator.endOfInline);
> +		       LayoutUnit bpm =
getBorderPaddingMargin(toRenderInline(child), childIterator.endOfInline);
>		       childMin += bpm;
>		       childMax += bpm;

Seems like we want to keep bpm a float to save an extra float conversion since
childMin and childMax are floats. Otherwise this lgtm!