[webkit-reviews] review denied: [Bug 87337] [Blackberry] WebKit's fullscreen mode needs to notify page client. : [Attachment 144786] Patch

[bugzilla-daemon at webkit.org]

Max Feil <mfeil at rim.com> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 87337: [Blackberry] WebKit's fullscreen mode needs to notify page client.
https://bugs.webkit.org/show_bug.cgi?id=87337

Attachment 144786: Patch
https://bugs.webkit.org/attachment.cgi?id=144786&action=review

------- Additional Comments from Max Feil <mfeil at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144786&action=review


> Source/WebKit/blackberry/Api/WebPage.cpp:5487
> +	  
static_cast<Element*>(d->m_fullscreenVideoNode.get())->document()->webkitCancel
FullScreen();

This line is not correct. The m_fullscreenVideoNode is only used by the
enterFullScreenForNode path (when fullScreenVideoCapable is true). So it will
always be zero here. Was this code path tested?