[webkit-reviews] review granted: [Bug 87688] Floats wraps incorrectly when top edge has subpixel precision : [Attachment 144883] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 87688: Floats wraps incorrectly when top edge has subpixel precision
https://bugs.webkit.org/show_bug.cgi?id=87688

Attachment 144883: Patch
https://bugs.webkit.org/attachment.cgi?id=144883&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144883&action=review


> Source/WebCore/rendering/RenderBlock.cpp:3968
> +	   FloatIntervalSearchAdapter<FloatingObject::FloatLeft> adapter(this,
logicalTop.round(), left, heightRemaining);

Why not roundToInt()?

> LayoutTests/ChangeLog:14
> +	   * fast/sub-pixel/float-wrap-with-subpixel-top-expected.html: Added.
> +	   * fast/sub-pixel/float-wrap-with-subpixel-top.html: Added.

Skip this test on platforms without sub-pixel layout.

> LayoutTests/ChangeLog:17
> +	   *
platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.p
ng:
> +	   *
platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.t
xt:
> +	   *
platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expect
ed.txt:

Will these turn Mac bots red? You can mark these as optionally failing on
Chromium-Mac then run the rebaseline tool to verify.